Added tentative build script for GitHub #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <[email protected]>
joebowbeer
reviewed
Sep 11, 2025
| run: npm install | ||
|
|
||
| - name: Build package (install dependencies, lint, prettier, build) | ||
| run: npm run build |
There was a problem hiding this comment.
Strictly speaking npm run build isn't needed or used since ts-jest is running tests
But running lint here would be a good idea
| uses: codecov/codecov-action@ad3126e916f78f00edff4ed0317cf185271ccc2d # v5.4.2 | ||
|
|
||
| publish: | ||
| needs: build |
There was a problem hiding this comment.
Maybe name that job "test" since it doesn't build but it tests
Co-authored-by: Joe Bowbeer <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Joe Bowbeer <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Joe Bowbeer <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Joe Bowbeer <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Joe Bowbeer <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
|
Fixes #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added build and publish workflows on the build.yml script